Speed up tests - #563
Closed
simonmar wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for fb-oss-glean canceled.
|
simonmar
force-pushed
the
speedup-tests
branch
2 times, most recently
from
July 9, 2025 12:37
a0e802f to
8f02693
Compare
Contributor
|
@iamirzhan has imported this pull request. If you are a Meta employee, you can view this in D78080251. |
Collaborator
Author
|
@iamirzhan sorry this one has compile errors, let me make it a draft until it's ready. |
simonmar
marked this pull request as draft
July 10, 2025 10:59
simonmar
marked this pull request as ready for review
July 10, 2025 11:34
We typically run each test case on at least 4 different DB flavours (memory, rocksdb, memory/stacked and rocksdb/stacked), and for each test we were recreating the exact same test DBs. To speed things up when there are multiple tests, this creates the test DBs once and shares them between all tests. Also: moved StringTest into AngleTest, it was a bit strange to have that one test case in a test by itself.
Contributor
|
@pepeiborra has imported this pull request. If you are a Meta employee, you can view this in D78080251. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We typically run each test case on at least 4 different DB flavours (memory, rocksdb, memory/stacked and rocksdb/stacked), and for each test we were recreating the exact same test DBs. To speed things up when there are multiple tests, this creates the test DBs once and shares them between all tests.
Also: moved StringTest into AngleTest, it was a bit strange to have that one test case in a test by itself.